opentelemetry-operator icon indicating copy to clipboard operation
opentelemetry-operator copied to clipboard
verified publisher icon open-telemetry

Add missing label servicemonitor

Open yuriolisa opened this issue 1 year ago • 4 comments

Description: <Describe what has changed.>

Add missing label for Service/Pod Monitors Link to tracking Issue: <Issue number if applicable> Resolves #2251 Testing: <Describe what testing was performed and which tests were added.> Added unit and e2e tests. Documentation: <Describe the documentation added.>

yuriolisa avatar Jan 29 '24 11:01 yuriolisa

Could we use manifestutils.Labels for these?

swiatekm avatar Jan 29 '24 11:01 swiatekm

Could we use manifestutils.Labels for these?

No, but I could include a PodMonitorSelector and ServiceMonitorSelector. WDYT?

yuriolisa avatar Jan 29 '24 12:01 yuriolisa

i meant to click request changes for that podmonitor issue

Added the comment and changed the PodMonitor matchLabels to the default one.

yuriolisa avatar Feb 12 '24 11:02 yuriolisa

looks like some legit e2e and lint failures

jaronoff97 avatar Feb 13 '24 16:02 jaronoff97