Mikołaj Świątek
Mikołaj Świątek
With #2652, we can now merge this and unblock other dependencies that need this.
> TBH I don't like that the operator uses the feature gate package from the collector. > > I would prefer to have a separate struct (with flags support for...
> I think this should only be in v2 i.e. apiVersion: opentelemetry.io/v1alpha2 This will let us take advantage of the work for https://github.com/open-telemetry/opentelemetry-operator/issues/901 (embedding a common fields struct) > Having...
I've thought about this a bit more, and I think I've arrived at a solution to the two-way binding problem. Our requirements are: * The TargetAllocator CR should have some...
I'm wondering if it wouldn't be better to first merge #2621, then add a v1alpha2 version of the embedded TA spec, take care of conversion, and then generating the CR...
I'd also like to merge #2623 first, then the conversion in this PR becomes trivial.
This is now ready for review. I've rebased my manifest generation changes on it, and everything works there as well.
I did some reconciliation tests and ended up switching to `AnyConfig` for the ScrapeConfigs field. I couldn't make it any nicer, so in the end there wasn't any reason to...
I think it's fine if they're part of the operator's main config struct for now. We can refactor this later if it's unwieldy. Right now we don't have a lot...
I've updated the issue with a checklist for the flags that need to be migrated. I'd like to keep this issue open to track the procedure across all the flags.