Suzanne Jin

Results 54 comments of Suzanne Jin

- [x] added default parameters for propd/propr/grea modules. Still need to find a better way to handle them though, see discussion in #302

close pr as it is treated in #431 and #385

hello @bjlang ! If we have two pathways with common steps, like for example: ``` path | method_diff | args_diff | method_cor | args_cor | method_enrich | args_enrich ------------------------------------------------------------------------------------------------- path1...

> Since the `variable_selection` subworkflow and with it the `filtervar` module aren't used anymore, can they be deleted? Besides it looks good to me! good point! they are removed now...

Hello @kmuench! Sorry for the late answer. There was an error in the README, it should be `custom_cutoffs = NA` just as @Tiltedkid replied!

Hey @BirkirRey! So sorry, I did not see your comment. I will check your pull request tomorrow morning Cheers

> Why don't we just remove `paramset_names` from the meta before we pass to the process? We can store the mapping to sample sets and re-associated after? How would you...

Actually the channel based way of saving output could still be interesting even the groovy objects solve caching issue. In this way, it also provides a way to save the...

yes i agree!! many of these parameters, like for example deseq2 specific column values, etc they should not be provided as parameter by the user, but instead fixed inside the...

Hello @grst From our side, our main priorities now is to finish #443 #433 and #422 . But I think, #443 is the big one, once it is done, the...