Denis Varlakov

The only difference I noticed since moving on CMake is that `.lib` folder has been renamed to `lib`. Build system rarely matters if you just link with generated library.

Do you plan to publish your crate? I did my fork for research purposes too. There's definitely a lack of PQ crates in Rust. Perhaps a large number of research...

I reproduced the same problem while using `ciborium` (which is always supposed to be `human_readable = false`) and `#[serde(flatten)]`. Things inside of `#[serde(flatten)]` have `human_readable = true`. I followed the...

I don't mind sending PR, but I'm not sure that changing `%` with `?` will actually work. Technically, we shouldn't make any assumptions on what `std::fmt::Debug` implementation outputs, it's supposed...

I don't know what's the best way to proceed tbh since I'm not familiar with otel at all. If the formatting is indeed not a part of the spec, it...

> So I guess we should maybe remove this attribute from the docs? It does make sense to me!

However, looking at the code, it might be not as trivial. Span kind is used here: https://github.com/tokio-rs/tracing-opentelemetry/blob/7f4409a935608bb89e970956217a91945f285b0f/src/tracer.rs#L82-L89 if we remove it, `should_sample` will always be called with `SpanKind::Internal`, that doesn't...

I was surprised to find out that env aliases are not supported, which was unexpected because there are aliases for short/long arg names. I think env aliases do improve usability...