Denis Varlakov

Hi @durgesh-pandey, thanks for contribution! Correct me if I'm wrong - from what I understood from the [thread] you pointed out in the code, the purpose of safe representation is...

I see the point — you need safe representation to replace bit clamping. The only property that safe representation may provide is protection against multiplication at Torsion base. We covered...

Sounds good, but all the operations are still mod \ell, not mod 8*\ell — ie. any arithmetic operation with torsion safe scalar produces scalar mod \ell. Do I correctly understand...

Currently torsion safe scalars contradict with the design of the library. Specifically, ECScalar must be mod group_order (ie. mod \ell), that's stated in the [documentation](https://docs.rs/curv-kzen/0.8.0-rc3/curv/elliptic/curves/trait.ECScalar.html). In order to add torison...

Great suggestions, @omershlo! 1) Polynomial multiplication could be easily added. I assume FFT is not difficult to implement. 2) What if I expose this method: ```rust impl Polynomial { pub...

> The main question here is if you consider serialization format public API or not Indeed, we should freeze serialization format at some point in the future. It's not expected...

Sure, take your time! I won't merge until PR is marked as ready for review. I just noticed that there are no unwraps anymore. Converting to raw bytes is also...

BigInt deserialization implementation has been improved in latest curv, it was not compatible with serde_json. See the PR: #145. Points/scalars deserialization has been changed as well: #143

Shouldn't we do the same for EncodedScalar?

@Sky-Nik we ran out of credits on Travis CI 🙂 I'll run tests locally