Denis Varlakov
Denis Varlakov
> the current version of curv is mostly iterator-based What do you mean? Could you give an example? > earlier we were concerned with Vec reallocations Actually, I'm not sure...
I don't think that in this particular case vector gets reallocated. Since it's constructed from Iterator, it can use [`Iterator::size_hint`] in order to allocate sufficient space to avoid reallocations. Here's...
Moreover, (but I might be mistaken) every time we pass Scalar by value as an argument to some function, it gets copied and old version persist on stack without zeroing...
@Sky-Nik, > most curv methods do not take Scalars by value Indeed, we didn't take into account that aspect while were designing the library. Good opportunity to improve it. I...
@elichai, > Your code still returns KeyPair by value, meaning it will copy it into the caller stack. Doesn't it writes directly to caller stack? It writes to own stack...
Can't say anything about that crate, I haven't used it. But looks like it erases stack, yeah, but you need to choose accurate amount of pages to be cleared.
Это было действительно неожиданно. Уж не думал, что столь незамысловатый и простой подход даст настолько меньше производительности, нежели от него ожидалось. Не так много пишу на php, не имел такой...
`rust-crypto` dependency bothers us a lot, so we're removing it: https://github.com/ZenGo-X/curv/pull/137. Though it's one of minor challenges, a lot of other things block us from being wasm-compatible right now, e.g....
Hi @tmpfs, as you correctly observed, `multi-party-ecdsa` depends on several crates that depend on `curv` as well, so they need to be upgraded first. Usually I update `multi-party-ecdsa` and its...
@tmpfs Note that if you have other dependencies that depend on `curv` (eg. `multi-party-ecdsa`), then you need to turn off default features for them too, ie: `multi-party-ecdsa = { git...