sudlud comments

Results 206 comments of


                                            sudlud

Fix (Core/Marker): quest markers disappearing on NPCs

is there any update on this, please address the review comments

Fix (Core/Marker): quest markers disappearing on NPCs

closing this PR as the author does not responded to reviews. Please feel free to re-open this PR and address the open reviews/comments.

fix(Scripts/Spell) Added random whispers of the Death Knight Newbie Village Lich King

Why close? :)

old ironjaw / old crafty have confirm bind on pickup dialogue

can confirm that `Old Crafty` in Orgrimmar also still shows the dialogue

Mail appears not to arrive if the receiving player was logged in when it was sent/received?

probably fixed with #18996

Linux: Support systemd socket activation for the worldserver game socket

Can you please try to avoid force pushing on PRs, it makes tracking changes after reviews quite hard

Linux: Support systemd socket activation for the worldserver game socket

I'd also agree to avoid additional dependencies if possible

Linux: Support systemd socket activation for the worldserver game socket

please. no force pushes, it makes tracking reviews and following changes impossible.

Linux: Support systemd socket activation for the worldserver game socket

please update the pr description for the latest version of the pr (e.g. no newly added dependency) i would also propose to make this configurable in worldserver.conf so it is...

Linux: Support systemd socket activation for the worldserver game socket

Also could you please add some test steps on how to test this on Linux