Steven
Steven
We have a test here https://github.com/vercel/nft/blob/main/test/unit/phantomjs-prebuilt/input.js Can you add a failing test case? Perhaps its a different version than [2.1.16](https://github.com/vercel/nft/blob/2a749dc31b87bd2f5104ceaedb4878c034a95d94/package.json#L103)?
Please add an integration test in `./test/integration` to confirm this works as expected, thanks!
Thanks for reporting! Would you like to submit a PR with the fix?
> version 5 requires node 14 at the minimum, which is probably too high for this package We can a target node 14 now that 12 is EOL https://github.com/vercel/nft/pull/318
The purpose of nft is to simulate Node.js module resolution. The existing webpack tests are trying to reverse the wrappers that webpack adds back to the original source code the...
Is this still needed? https://github.com/vercel/nft/pull/336#issuecomment-1443925199
Sounds good to me! If Node.js supports it, we want nft to support it too. Feel free to submit a PR with a test and I'll take a look! 👍
- PR titles don't have a convention and PR descriptions just need a why and how like you said. - Not really any conventions, we should probably add [style-guide](https://github.com/vercel/style-guide) as...
The comment here still holds true: https://github.com/vercel/nft/issues/389#issuecomment-1924595725 Feel free to make a new PR if you have a fix. Also note that Node.js 22 added a built-in [fs.glob()](https://nodejs.org/api/fs.html#fspromisesglobpattern-options) so it...
> even when they are not within the package boundary I never really understood why the package boundary was necessary. This was something @guybedford was very keen on adding. It...