nft icon indicating copy to clipboard operation
nft copied to clipboard

fix: Add special case for Serial Port binary (.node) modules

Open RogerHardiman opened this issue 1 year ago • 3 comments

Tested with prebuilds and compiling serialport from source

RogerHardiman avatar May 03 '24 11:05 RogerHardiman

Please add an integration test in ./test/integration to confirm this works as expected, thanks!

styfle avatar May 04 '24 02:05 styfle

Good idea to add an integration test. I noticed another one of the binary .node special cases had an integration test.

RogerHardiman avatar May 05 '24 14:05 RogerHardiman

Just a note to myself that currently one integration test fails with the error below before I add my new integration test

  ● should correctly trace and correctly execute sharp-pnpm.js

    Command failed: corepack enable && pnpm i



Test Suites: 1 failed, 3 passed, 4 total
Tests:       1 failed, 1368 passed, 1369 total
Snapshots:   0 total
Time:        530.549 s
Ran all test suites.

RogerHardiman avatar May 05 '24 15:05 RogerHardiman

This has been updated with an integrating test. The test code (serialport.js) throws an exception if the .node modules are missing,

RogerHardiman avatar May 08 '24 06:05 RogerHardiman

:tada: This PR is included in version 0.26.5 :tada:

The release is available on:

Your semantic-release bot :package::rocket:

github-actions[bot] avatar May 08 '24 16:05 github-actions[bot]