Steven comments

Results 553 comments of


                                            Steven

Opposite of ignore?

Can you share your use case? Are you publishing a package to npm that you want to work with `@vercel/nft`?

Opposite of ignore?

How about adding that special case to nft?

Opposite of ignore?

A PR with an integration test would be welcome, thanks! (see #262 for an example)

`pkg.main` is always parsed as a script, even if it's not

Yeah I think we could exclude `.html` even if explicitly defined in `main`. Technically this usage is valid today if `index.html` is actually a JS file and Node.js will happily...

demonstrate mjs file identified as esm, but handled as cjs

@cb1kenobi This test is passing https://github.com/vercel/nft/actions/runs/6384547761/job/17327429573?pr=364#step:8:6107 Is that because it doesn't set `mixedModules: true`?

LMDB not traced due to dict/dict.txt

Please provide the steps to reproduce the issue

Many chained concat() calls can cause trace to fail

Thanks for reporting this issue! I created a PR with a fix https://github.com/vercel/nft/pull/422

Looks like we're hitting this `NODE_GYP_BUILD` case correctly, however the AST is not understood and so `node-gyp-build` is never executed. https://github.com/vercel/nft/blob/c16e7945c3f3221616567356d9abc2e824bf38cd/src/analyze.ts#L755

fix: support datadog-pprof

I took a stab at fixing this properly in PR https://github.com/vercel/nft/pull/419

`RangeError: Maximum call stack size exceeded` - For exports parsed into a lot of nodes

Thanks for reporting this issue! I was able to reproduce with a single file ``` curl -JLO "https://raw.githubusercontent.com/sidorares/node-mysql2/675dd0411017053375a18248c38a2b8b55de24ed/lib/constants/ssl_profiles.js" npm install -g @vercel/nft nft print ssl_profiles.js ``` It looks like you...