Steven comments

Results 553 comments of


                                            Steven

ncc fails with package etcd3

Thanks for the repro steps! This code is quite dynamic since the protobuf file path is never passed directly to a fs.readFile(), and instead is passed to `loadSync()` https://github.com/protobufjs/protobuf.js/blob/95b56817ef6fb9bdcb14d956c159da49d0889bff/src/root.js#L244 https://github.com/protobufjs/protobuf.js/blob/95b56817ef6fb9bdcb14d956c159da49d0889bff/src/root.js#L85...

Are there multiple js files in the directory packaged by NCC?

Could be an asset read like `fs.readFile('./foo.js')` Also could be from `--asset-builds` flag.

ESM + Relative imports without .js extension causes "ReferenceError: require is not defined in ES module scope"

Does it work when running your source file with `node` directly? Typically you need either `{ "type": "module" }` in package.json or rename the file to `.mjs` https://nodejs.org/api/esm.html#enabling

ESM + Relative imports without .js extension causes "ReferenceError: require is not defined in ES module scope"

- See also: https://github.com/vercel/ncc/issues/791

ESM mode still uses "require" within an ESM module

This sounds like a duplicate of https://github.com/vercel/ncc/issues/749

ESM mode still uses "require" within an ESM module

Oops, I meant duplicate of #791

feat: allow exclude all external without make a super long external list

How would ncc know what to use for external?

feat: allow exclude all external without make a super long external list

Sounds good. How about a new flag like “--external-dependencies” to opt in?

Issue with ESM and node:protocol

I was able to reproduce with a `index.mjs` containing `import fs from 'node:fs'; console.log(typeof fs);` which outputs: ``` import { createRequire as __WEBPACK_EXTERNAL_createRequire } from "module"; /******/ "use strict"; /******/...

Issue with ESM and node:protocol

Looks like webpack always emits CJS for `node:` for some reason https://github.com/webpack/webpack/pull/12693 Looks like it needs Node.js 16 or newer.