stuartmorgan
stuartmorgan
Yes, since there's no impact from not handling it (as it's just example code), just ignoring it in this PR and then removing the `ignore`s in the second and third...
Overriding version and changelog checks: the changes are `// ignore`s, which are exempt.
This will need to wait for https://github.com/flutter/packages/pull/3417 to land and then be re-merged, to avoid breaking post-submit.
I expected that, but misremembered and thought we had a way to override it in presubmit (which is why I suggested waiting rather than splitting it initially, sorry about that)....
Removing the overrides since those changes will be moving to the other PR.
> because this change adds limited value to end users The bar we generally use for our continuous release model is not really "value to end users", but "has an...
> * [✅] The title of the PR starts with the name of the package surrounded by square brackets, e.g. `[shared_preferences]` Please don't check boxes without having done the checklist...
> I did not receive any response regarding [this](https://github.com/flutter/plugins/pull/7015#discussion_r1108046529). Let me know if it seems alright? You have not addressed [my original comment](https://github.com/flutter/plugins/pull/7015#discussion_r1106166236), so no, this still has the same...
@AmanNegi Are you still planning on updating this PR with tests?
> I'm unable to think as to how to test the`SharedPreferences` object As explained previously, the goal is not to test `SharedPreferences`, it is to test the plugin's code, which...