Alex Strick van Linschoten

Results 41 comments of Alex Strick van Linschoten

I had the same with `fastai.vision.all`. This fix worked for me as well.

Thanks for the submission, @SangamSwadiK. This tool hasn't been updated since October 2021, so I think it fails our criterion of being 'actively maintained'. Welcome to hear if you think...

Thanks for the submission, @SangamSwadiK. This tool hasn't been updated since July 2020, so I think it fails our criterion of being 'actively maintained'. Welcome to hear if you think...

Thanks! That other PR was what inspired me actually. The main thing I have to figure out is how to match the slightly different behavior and interface used by Prodigy...

@fa9r @dnth could one of you give this a quick review before I merge it in?

Thanks for the reviews and comments. I've now updated / amended things as per the feedback. I think my feeling around having it as a built-in materializer was that Pillow...

Thank you for this. It would be useful to have some tests for this addition so that we know it's doing what it's supposed to do. Would you be able...

I think at a minimum we'd want some unit tests to ensure that the ignored columns were really being ignored. I would maybe ignore the actual 'integration' tests (of the...

Hi, sorry for the delay in getting back to you on this. I think you could try changing `ignored_columns:List[str]` and making it `ignored_columns: List[str] = None`. Not sure if this...

> Can't do None as default argument, because mypy is throwing error, I guess default can be just an empty list []. `src/zenml/integrations/evidently/steps/evidently_profile.py:130: error: Incompatible default for argument "ignored_columns" (default...