Alex Strick van Linschoten

Results 164 comments of Alex Strick van Linschoten
trafficstars

@schustmi @SangamSwadiK I think it's reasonable to add the columns to the `EvidentlyProfileConfig` object. I don't see any reasonable why that wouldn't be work. But it will change a few...

One other point... in order for the tests to run on our Github CI system, you'll need to add the Evidently integration to be installed for unit-tests. You can do...

@SangamSwadiK Seems like all the tests are failing currently.

Sounds good, @Tob-iee. Is everything clear in terms of how you think you'd go about implementing it? I assume you'll reference the local secrets manager when you work on this?...

Yes of course. Maybe we could start with your understanding of the problem / what needs doing? Or is the description unclear and you'd want me to explain more?

I think there would be no need for the interactive part once you are passing in a dict or JSON. You can see the final clause of the condition [here](https://github.com/zenml-io/zenml/blob/080b9f30b75dbf87b24bdfed488c405d44ac2d8c/src/zenml/cli/secret.py#L137])...

The secrets get used by our Secrets Manager stack component. You can read more about it [here](https://docs.zenml.io/advanced-guide/manage-your-secrets) and also check out the practical example [here](https://github.com/zenml-io/zenml/tree/main/examples/cloud_secrets_manager).

Hi I don't see any messages from you. You're posting in the ZenML slack?

![ScreenShot 2022-06-17 at 12 35 07](https://user-images.githubusercontent.com/3348134/174282013-7a0cf565-0e92-485e-8285-35ca8cd763ad.png)

Thanks for asking, @testdepthanalytics! I'm unsure of the status of this on the side of @Tob-iee. (Are you still working on it, @Tob-iee?) I'll also take a look to see...