StratisBitcoinFullNode
StratisBitcoinFullNode copied to clipboard
Bitcoin full node in C#
I see there is a method in NetworkPeerFactory https://github.com/stratisproject/StratisBitcoinFullNode/blob/4c1685abfb7e0b4f486b486fa4189f76034cedaf/src/Stratis.Bitcoin/P2P/Peer/NetworkPeerFactory.cs#L162-L181 that's only used by one Test https://github.com/stratisproject/StratisBitcoinFullNode/blob/4c1685abfb7e0b4f486b486fa4189f76034cedaf/src/Stratis.Bitcoin.IntegrationTests.Common/EnvironmentMockUpHelpers/CoreNode.cs#L232 I think it's not a good practice to have implementations just for test needs....
We must be careful when implementing a Dispose() method or when we need to dispose inner disposable objects, because if we don't handle a potential throw, we may end up...
Just saw the changes on #3125 We can improve it further, preventing a double array allocation when we do array.Skip.ToArray It can be achieved easily by computing the size of...
Coin selector in transaction builder has some problems (mainly it does not filter out UTXO that are not needed) This is copied over from NBitcoin which is taken from and...
Rewind data need to be cleaned. At block 330000, my hard drive took 20GB of space when the UTXO was only 2GB. 2 observations: * We do not need rewind...
The `debug` log output is not used enough, we should go over the code and make sure a lot more code path use trace debug. Also ensure the `-debug` flag...
Currently they end up being mapped to RPC_INTERNAL_ERROR Note: Many RPCMiddlewareTests will have to be refactored if this is changed.
See: 