Steven Lambert

Results 173 comments of Steven Lambert

Update on this. Thanks for your patience. We found someone to do the review. I'll try to have a pr to your branch with the changes they suggested within the...

@nadavkav Just letting you know I opened a pr on your fork with the suggestions from the translator. Let me know if you have any questions.

The suggestions can be found here https://github.com/nadavkav/axe-core/pull/1/files. It's a pr to your fork of axe-core. The flow would be to look at the differences between your file and the suggestions...

@nadavkav thanks for accepting the changes. It looks like our build is failing because your fork is out of date. I'll make another pr to update it for you.

Here's the pr https://github.com/nadavkav/axe-core/pull/3

Reviewed for security

Work was completed in https://github.com/dequelabs/axe-core/commit/f61f825843ec323fbe7ebb7096bf4c7341f10feb but accidentally pushed to develop directly instead of a pr. The negative tabindex will cause the rule to not run, meaning it will return as...

Thanks for the suggestion. Right now the only option available for rules in `axe.run` is the `enabled` option, so we'll have to discuss if we want to expand that.

@Capocaccia `reviewOnFail` is available as a configuration option for axe rules. That is, when creating a new rule you can pass it as an option: ```js axe.configure({ rules: [ {...

@Capocaccia Were you trying to make a pr directly using the file edit flow in GitHub? If so you'll need to fork the repo and make your changes in your...