axe-core icon indicating copy to clipboard operation
axe-core copied to clipboard

New Hebrew he.json

Open nadavkav opened this issue 3 years ago • 4 comments

Translated by Or Bar-Josef from the Weizmann institute of science, Israel.

<< Describe the changes >>

Closes issue:

nadavkav avatar Apr 17 '22 12:04 nadavkav

Thanks for the new translation! We'll find someone to review the changes who can speak Hebrew, so it may take a bit to get a review.

straker avatar Apr 18 '22 14:04 straker

Thank you @straker

nadavkav avatar Apr 18 '22 16:04 nadavkav

Update on this. Thanks for your patience. We found someone to do the review. I'll try to have a pr to your branch with the changes they suggested within the next few days.

straker avatar Aug 01 '22 15:08 straker

Thank you

nadavkav avatar Aug 01 '22 18:08 nadavkav

@nadavkav Just letting you know I opened a pr on your fork with the suggestions from the translator. Let me know if you have any questions.

straker avatar Aug 11 '22 20:08 straker

@straker , I can not find the reviewer's suggestions please send a link. And I do not understand the flow, do I need to do something?

nadavkav avatar Aug 14 '22 07:08 nadavkav

The suggestions can be found here https://github.com/nadavkav/axe-core/pull/1/files. It's a pr to your fork of axe-core. The flow would be to look at the differences between your file and the suggestions from the pr and if you accept all the changes to merge the pr on your fork. That should automatically update this pr with those changes.

straker avatar Aug 15 '22 15:08 straker

@nadavkav thanks for accepting the changes. It looks like our build is failing because your fork is out of date. I'll make another pr to update it for you.

straker avatar Aug 16 '22 15:08 straker

Here's the pr https://github.com/nadavkav/axe-core/pull/3

straker avatar Aug 16 '22 15:08 straker

Reviewed for security

straker avatar Aug 17 '22 14:08 straker