Istvan Toth
Istvan Toth
I believe I have addressed your comments which do not change the API. I will work on your comments that introduce incompatible changes now.
Can you take another look at the current patch @michael-o ? I have implemented most of your suggestions, but I had a few more questions comments regarding KerberosConfig.
Rebased to current master
I have reverted the removals. I don't see what alternative package name we could use instead of "org.apache.hc.client5.http.auth" Using another package might also break package level visibility. Maybe I could...
I don't think that removing deprecation is problem, especially as these classes were deprecated without providing a replacement, not because they were replaced by something.
I have made the discussed changes.
Thank you @ok2c. I have rebased the patch and temporarily disabled japcmp. I have also added and @Internal annotation to HttpAuthenticator, I cannot imagine realistic user code calling that directly....
I don't think that duplicating HttpAuthenticator is a good idea. For the authentication shemes, a case could be made for duplicating them, as those are pluggable components. However, HttpAuthenticator is...
Thank you. I have already done that.