Istvan Toth

Results 504 comments of Istvan Toth

Thanks for your response. Yes, the objective is to somehow get sqline to get to use toString() for temporal types. Using the empty string as a magic value to enable...

Uploaded the new PR #478 , @julianhyde.

Can you clean up the commit message ? Use of colons, dashes, etc is inconsitent.

The commit message doesn't match the JIRA ticket description

The convention is to use the JIRA description for the first line of the commit message. If you think that the JIRA description is not sufficient, you may want to...

We still have time, I agree that it'd be cleaner if we removed any 2.3 leftovers in a separate ticket.

Please update the commit message, @richardantal

Thank you. Let's get get back to this once 2.6.0 is out.

I cannot remove the "request changes" review without approving, which I am not ready to do until we have 2.6.0 final to test with. (and the PR also needs to...

BTW could you please add 2.6 to the multibranch jenkinsfile ?