PHOENIX-7172: Support HBase 2.6

[richardantal]

Remove files left from Hbase 2.3 compat module

[richardantal]

I removed the HBase 2.3 compat module as it should have been removed in PHOENIX-6877 And added the new 2.6 modules, git recognises these as renamed some files which is not ideal, maybe it should be done separately. Also this change can only be merged after the 2.6 release

[stoty]

We still have time, I agree that it'd be cleaner if we removed any 2.3 leftovers in a separate ticket.

[stoty]

Please update the commit message, @richardantal

[stoty]

Thank you. Let's get get back to this once 2.6.0 is out.

[stoty]

I cannot remove the "request changes" review without approving, which I am not ready to do until we have 2.6.0 final to test with. (and the PR also needs to be updated with the final version)

[stoty]

BTW could you please add 2.6 to the multibranch jenkinsfile ?

[virajjasani]

Now that HBase 2.6.0 is released, we can resume here?

[stoty]

Kicked off a new CI build

[stoty]

Can you rebase @richardantal ? The patch doesn't apply cleanly anymore.

[stoty]

It is based on an old version, from before we removed 2.4.0. support from HEAD.

[stoty]

Also this still uses 2.6.0-SNAPSHOT. Updating to 2.6.0-hadoop3 should let the CI run fully.

[stoty]

Also update the Phoenix version to 5.3.0-SNAPSHOT in the new compatibility module, I've spent an hour trying to compile it.

[stoty]

CompatOmidTransactionTable also needs to be updated.

[stoty]

I see that hose issues are fixed.

Sorry, I must have used an older patch.

[stoty]

However, most of the checkstyle warnings are relevant.

I'm not sure why the javadoc check failed.

[virajjasani]

Does this work fine locally? mvn clean javadoc:javadoc -Dskip.code-coverage -DskipTests=true

[stoty]

Yes, it works after mvn install. Yetus should have taken care of that.

[virajjasani]

Looks like we need to add support to run tests against 2.6 profile https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-mulitbranch/job/master/688/ ?

[stoty]

Yes, opened https://issues.apache.org/jira/browse/PHOENIX-7333 for that.

[virajjasani]

Thanks @stoty @richardantal for this great work!

Reg the precommit jenkins builds, i just noticed that 2.6 builds are getting aborted (whereas 2.4 and 2.5 builds get failed with few test failures but at least the builds are not aborted).

[stoty]

You mean the multibranch jenkis job, @virajjasani ? All precommit builds are running with 2.5 only at the moment.

[virajjasani]

My bad, yes multibranch builds of master and 5.2

[stoty]

Opened https://issues.apache.org/jira/browse/PHOENIX-7339

[virajjasani]

Thanks a lot @stoty @richardantal for getting HBase 2.6 support in and stabilizing tests. It seems like one last thing we might have to do is adjust client version for 2.6 profile? https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-mulitbranch/job/master/703/testReport/junit/org.apache.phoenix.end2end/BackwardCompatibilityIT/MatrixBuild___Matrix___HBASE_PROFILE____2_6____BuildAndTest___initializationError/

[stoty]

Thank you, looks like you're right. Opened https://issues.apache.org/jira/browse/PHOENIX-7359 to track.

Istvan

On Fri, Jul 12, 2024 at 8:57 PM Viraj Jasani @.***> wrote:

Thanks a lot @stoty https://github.com/stoty @richardantal https://github.com/richardantal for getting HBase 2.6 support in and stabilizing tests. It seems like one last thing we might have to do is adjust client version for 2.6 profile? https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-mulitbranch/job/master/703/testReport/junit/org.apache.phoenix.end2end/BackwardCompatibilityIT/MatrixBuild___Matrix___HBASE_PROFILE____2_6____BuildAndTest___initializationError/

— Reply to this email directly, view it on GitHub https://github.com/apache/phoenix/pull/1793#issuecomment-2226188945, or unsubscribe https://github.com/notifications/unsubscribe-auth/AACKM5KIPWVSNSLV2ZCIA53ZMARIPAVCNFSM6AAAAABBWTJIDWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEMRWGE4DQOJUGU . You are receiving this because you were mentioned.Message ID: @.***>

-- István Tóth | Sr. Staff Software Engineer Email: @.*** cloudera.com https://www.cloudera.com [image: Cloudera] https://www.cloudera.com/ [image: Cloudera on Twitter] https://twitter.com/cloudera [image: Cloudera on Facebook] https://www.facebook.com/cloudera [image: Cloudera on LinkedIn] https://www.linkedin.com/company/cloudera

---