Istvan Toth

Results 504 comments of Istvan Toth

You mean the multibranch jenkis job, @virajjasani ? All precommit builds are running with 2.5 only at the moment.

Opened https://issues.apache.org/jira/browse/PHOENIX-7339

Thank you, looks like you're right. Opened https://issues.apache.org/jira/browse/PHOENIX-7359 to track. Istvan On Fri, Jul 12, 2024 at 8:57 PM Viraj Jasani ***@***.***> wrote: > Thanks a lot @stoty @richardantal >...

merged manually. Note that 5.2 still does not have this.

I have tested this now, but the shading time difference is seems to be minimal. On my machine it takes ~3:20 with the shaded sources, and ~3:05 without them. I...

Ouch. That's extremley slow. Is it on a spinning rust HDD ? Or some slow NAS ?

This is a pom only change, and #1736 doesn't touch the poms, so I wouldn't expect them to confict in any way.

Also, I'm going to merge the phoenix-server shading refactor soon (another pom only change), It would probably be a good idea to add this change there as well.

I suggest using a more generic name, like PhoenixMasterObserver. This will make our lives easier if we ever need to add more features to it.

Also, since this is a broad topic, perhaps we could split this feature into its separate JIRA ?