phoenix
phoenix copied to clipboard
apache
PHOENIX-628 Support native JSON data type
Can you clean up the commit message ?
Use of colons, dashes, etc is inconsitent.
The commit message doesn't match the JIRA ticket description
Can it be different from the JIRA description? I think the description has a recommendation - can I add the message as "Adding JSON native datatype and JSON functions" - That would be more relevant to the commit instead of the JIRA description?
The convention is to use the JIRA description for the first line of the commit message.
If you think that the JIRA description is not sufficient, you may want to change the JIRA ticket description, just keep it in sync with the commit message.
It's good to continue the review, however just wanted to bring up this discuss thread: Discuss thread: https://lists.apache.org/thread/xhwqfwytlklylt6kwqm1botsxr7dd4zb
I am hopeful that in a couple of weeks, we should be well positioned to get this PR move forward, but review can definitely continue in parallel. Thank you @ranganathg!
Re-triggered after fixing build failure on master branch: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1780/16/
Since the last build had flaky, triggered a new build: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1780/23/