Stijn Moreels
Stijn Moreels
Yeah, had this implemented myself but didn't include the 'expected' result or the name in the test so it could combine multiple manual case data tests together (theory in theory...
Hi! They're could be more of course. These were just the ones I thought were the most valueable to add from an application security perspective.
I tried to follow the style guidelines and way of working, please let me know if I did anything wrong. Happy to help! 👍
> Looks good from my end. I only have some questions that other maintainers (@dustinmoris) should weigh in on. > > So far Giraffe doesn't have many error messages it...
Ok, that's fine by me! 👍 I'll change this to your needs. Although, in the negotiation example, the exception handling (unacceptable handler) is passed not as the first parameter.
> This might interest you https://devblogs.microsoft.com/aspnet/improvements-in-net-core-3-0-for-troubleshooting-and-monitoring-distributed-apps/ That's nice! So we may not need a dedicated correlation approach in Giraffe. Super library, btw. I maybe suggest some other functionality related to...
I think it's still an option to discus this. But it;s not a problem to discard it either. It seems helpful to have some basic correlation handlers here.
Ah, shoot, didn't see that one. Maybe that would be ok, too. I'll try that. Thx!
Aha, found everything I needed. Thx for this! 👍
Maybe an idea to create an extra generator that generate the built-in `System.Range` from an `Interval`? But that may be overdoing it.