Stijn Moreels

Results 140 comments of Stijn Moreels

> lowercase or camelCase ? Ah, yes, my bad 😅 , was distracted with lower-case URL's. It's camelCase, indeed.

> Sounds good, I would like to pick this up to start contributing on this repo. Ok? Amazing! 🥳 That's really great of you. Let us know if you come...

> After creating this issue, and after a chat with @spasal , I am actually quite curious on how this will impact the built-in Function-logging stuff. We'll see 😄 ....

Will have to wait until Serilog compiles to the latest version: https://github.com/serilog/serilog-aspnetcore/issues/245

Ah, I remember. This is because of the tedious way that Azure Functions is set up. Because several internal workings are hidden and not available for customization, we had to...

> But what about correlating your own custom traces to the correct request, because they're currently not correlated. This should work already. Are you sure you selected the 'correct' traces?...

That's different from my experience, and I also used a fresh template with only configuring Application Insights via the provided variable. 🤔 Since your dependency is logged as a trace...

Interesting. But the Arcus request tracking is also there, right? That doesn't fix a little bit the problem? Otherwise, yeah, definitely a thing to consider.

The way the Serilog request middleware component is set up, it seems that they do kind of the same thing as we do with the HTTP request tracking middleware, but...

Great to have you working on this! This repo is not an easy one to contribute, so awesome job! 👍 To test that the Serilog actually uses the local file...