Results 593 comments of Stephen Haberman

@PhilipMantrov nice! Would be amazing to get this fixed. I think as-is, the added code isn't going to actually get output? Or will it? Usually code within that `makeUtils` function...

@PhilipMantrov thanks for adding the test! I'm good to merge this once the build is passing.

@TakeOver happy to have you fork the repo; if you want to contribute here I'm happy to merge PRs as well. For this one, it took a few iterations and...

:tada: This PR is included in version 1.128.0 :tada: The release is available on: - [npm package (@latest dist-tag)](https://www.npmjs.com/package/ts-proto/v/1.128.0) - [GitHub release](https://github.com/stephenh/ts-proto/releases/tag/v1.128.0) - `v1.128.0` Your **[semantic-release](https://github.com/semantic-release/semantic-release)** bot :package::rocket:

Hey @YannPerthuis yeah, I get what you're saying. I think putting `GrpcWebImpl` into like a single `grpc-web-impl.ts`; we do something similar here: https://github.com/stephenh/ts-proto/blob/main/src/plugin.ts#L36 Where we push an extra file to...

I think something like `ts-proto-grpc` / `ts-proto-twirp` / etc. dedicated npm packages would be good to provide clients with a way to get the set of dependencies they want. But,...

Hey @shimonmagal ; nothing to add, but great to hear that #380 's approach works well for what you'd like to do.

@sczrz I am not personally a NestJS user, but I believe the core issue here is that the ts-proto / NestJS integration currently works mostly by structural typing; i.e. ts-proto...

@jsbrain I'm pretty sure those options are for using the `proto-loader-gen-types` messages and `protobuf.js`, which ts-proto does not use / is an alternative too. Like here: ``` const packageDefinition =...

Hm, yeah, so that part of the output comes from: https://github.com/stephenh/ts-proto/blob/main/src/generate-grpc-web.ts#L64 And we can `inputType` from: ``` const inputType = requestType(ctx, methodDesc); ``` Which uses `methodDesc.inputType` (which is normally `.package.SomeMessage`)...