Stephen Haberman
Stephen Haberman
@fenos hey, sorry for the delay here; yeah I agree `fromJSON` should be able to do runtime type-checking (probably all the time, right? I.e. it could be a configuration flag...
@altro3 FWIW reopening this b/c I think it's a great idea; long.js doesn't support ESM and that's been annoying a few times.
Hi @andness ; ts-proto primarily targets proto3, which removed `required`as a keyword, so there is not a way to have required sub-messages in proto3. I assume you're using a proto2...
Ah interesting, no, we don't support that. I could see supporting by something like: * Have `Error.encode` return a tagged `Buffer & { encodes: 'Error'}` * Have the `Message.encode` type...
@paralin I think you've been in the guts of ts-proto/ts-poet enough that you've probably discovered this, but in theory this can be fixed by just adding a `t:` prefix to...
Hm, yeah, @Larkooo I'd generally recommend using the `oneof=unions` option, which should probably be the default, but in the case of `oneof=unions` not being in use, having optional keys for...
Hey! Thanks, glad you're enjoying ts-proto! > complete request a design choice or an implementation detail Yeah, it's a design choice on my part insofar as wanting the type-safety of...
@adayNU yep, that sounds like a good idea; a PR would be great!
Yep, good point / +1 to a hard-coded value. We could someday have like a `prefixFile=./my-custom-prefix.txt` opt to override it, but I assume for now we could drop basically any...
Ah sure, sounds good I guess. I haven't worked in a schema with that convention, but seems useful, especially for longer enum names. I'd be open for yet-another-config-flag to turn...