Results 591 comments of Stephen Haberman

Fwiw I wouldn't be against some sort of cute flag like `--ts-opt=dedupEnumPrefixes` which would, for each enum: * Split a name like `AAA_BBB_CCC` on `_` * Find the longest common...

Hey @sallustfire , glad to hear it's working well for you! Yeah, I think a `fileSuffix`-type option would be nice; probably around in this part of the code: https://github.com/stephenh/ts-proto/blob/main/src/plugin.ts#L30 A...

@pcj would you mind creating a new `integration/...` test/example with a `parameter.txt` that has the `-M` opt passed in? That will be the best way to make sure this feature...

@paralin I believe this PR would hopefully help you replace these lines: ``` + const thisProject = 'github.com/aperturerobotics/starpc'; + if (ourModulePath.startsWith(thisProject)) { + // throw new Error(ourModulePath + ' :...

@paralin awesome; thanks for rebasing. Two questions: a) I think @pcj was going to try my suggestion of moving the slice point to `createTypeMap`, because then the `-M` option could...

> How would that work if two protobuf files have the same package name > but are from different locations in the tree? ...how does protoc-go handle it? :shrug: :-)...

Ah sure, @iamricard , that'd be great; I think where the PR is at is: a) try the approach in this comment: https://github.com/stephenh/ts-proto/pull/597#issuecomment-1156928656 Which would basically be a new PR,...

This should be fixed in #672 ; thanks @iamricard !

@AaronDewes as far as I understand, including the file extension in imports has historically been not recommended. Is there something specifically different about Ind and/or your setup? I.e. are their...

Oh wow...you're right: https://nodejs.org/api/esm.html#esm_mandatory_file_extensions Huh. I guess we could add another option, like `--includeFileExtensions` ... or the file extensions don't _hurt_ in non-ESM mode, so maybe we should always do...