Stephen Haberman
Stephen Haberman
@jessmorecroft yeah, fwiw I'm definitely in your camp re general disappointment with how protobuf has handled optional/required over the years. But otherwise, yeah a PR would be great, with the...
I'd had issues in the past with `namespace` being AFAICT basically "soft deprecated" within TypeScript, i.e. it was a pre-ESM modules sort of thing, and outputs like Babel don't support...
@zlk89 makes sense! If you want to submit a PR, that'd be great.
I dunno, not 100% against it, but I think the existing output is ~slightly more idiomatic JS/TS where "maps" are, IMO anyways, almost always just objects with keys and not...
Huh, I was going to say that, because of proto3's default values are not serialized: https://developers.google.com/protocol-buffers/docs/proto3#default That we can't really know if the client "did not set `product` at all"...
@ajayjaggi97 hrm, yeah, I don't have any ideas; in theory the `ts-proto` code is exactly the same in both, so it'd probably be differences in the underlying protobuf-js/minimal code that...
Ah yeah, you are probably running into this: https://github.com/stephenh/ts-proto/blob/main/src/types.ts#L254 You could probably make `notDefaultCheck` return `Code | undefined`, instead of `Code`, and in the "there is no v.number === 0"...
Hey, thanks for the report! I'm not really surprised `Any` has some rough edges, I haven't personally used it yet and there are also aren't any test cases that cover...
@philikon sure, that sounds like a good idea. Thanks!
I looked a little bit at this, and the proto2 docs on `optional`: https://developers.google.com/protocol-buffers/docs/proto#optional > When a message is parsed, if it does not contain an optional element, the corresponding...