Stephen Haberman
Stephen Haberman
Hi @NimrodAvni ; @Vilsol just landed a PR that outputs options, if you use the `outputSchema` flag: https://github.com/stephenh/ts-proto/pull/437 It looks like you want the option output as part of the...
@NimrodAvni ah sorry, not really; @Vilsol I wasn't really following the issue with `Exact`; right now the ts-proto test suite runs on both node 14.x and 16.x, so I'm surprised...
@Vilsol FWIW while bumping to the latest TypeScript in #603, I saw some `Exact` weirdness in `ts-proto-descriptors`, which somewhat magically went away when I bumped `ts-proto-descriptors` to the latest TypeScript....
@paralin thanks for getting that in! Yep, I only disabled strict checks b/c I was rushing to get `ts-proto-descriptors` released for your PR. With your `unknownFields` fix merged, I just...
Yeah, I guess that makes sense. I'm a little concerned that this might be a breaking change, or at least mean downstream users get peer dependency warnings, but we can...
Ah yeah, I should have done a pull request, but this change even broken ts-proto's test suite, b/c the peer dependencies, specifically protobufjs, weren't installed automatically. So I've reverted this...
@D4nte I believe the `ts-proto-descriptors` is slightly different, i.e. afaiu it should have a direct dependency on `long`, which you're right it's missing; I believe I've fixed in #275 ,...
@psalz isn't `protobufjs` already a dependency of `ts-proto`? ...fwiw I think personally in downstream projects, I would mark ts-proto as a devDependency (it's a code generator that is only used...
Huh, that's interesting. I guess the next js restriction makes sense, insofar as it's expected a valid JSON value (I assume) and undefined as a value is not valid JSON....
> Option 3 could work, but smells really-really badly. I'd like to avoid it if we can. Yeah. Just kind of thinking, `JSON.stringify` already "does extra stuff". E.g. it calls...