Boris Nagaev
Boris Nagaev
@hugohn Great work! Does `/**` in descriptors mean a combination of `/0/*` and `/1/*`? I.e. a receive and a change descriptor.
@Crypt-iQ > I couldn't reproduce the race condition with the attached test, do you have an error trace of it? I pushed branch [reproduce-race](https://github.com/starius/lnd/tree/reproduce-race) to my fork. In that branch:...
> @starius - I think these unit test failures are related to this PR - maybe take a look at fixing those up first & then re-ping reviewers when ready?...
> Sorry a bit late in the game, but is there an issue page describing what the issue is? @yyforyongyu Thank you for the suggestion! I opened https://github.com/lightningnetwork/lnd/issues/9308 to describe...
I squashed the last commit (https://github.com/lightningnetwork/lnd/pull/9140/commits/deeacc62478bbe5f6b8fe1f2ee6cae02e3d7c8c1), rebased and used GoroutineManager from fn v2. Fortunately fn v1 and fn v2 can be used simultaneously!
Squashed the commits.
@yyforyongyu > The other approach is simply removing the wg.Add - why do we need it or am I missing anything here? If we remove `wg.Add`, we would end up...
I removed SweepFeeProvider and moved parts of the logic to `loopOutSweepFeerateProvider` (method GetConfTargetAndFeeRate). Decided to keep urgent logic and floor logic. High prio logic is removed. ---- New description of...
I tested the PR in regtest simulating changing of feerate environment. It works! But I found a bug in the approved version of the PR: loopout.go calls AddSweep after sweepbatcher...
Superseded by https://github.com/lightningnetwork/lnd/pull/8955