Boris Nagaev
Boris Nagaev
I managed to reproduce the original bug in regtest (LND 0.19.0). In LNG log I see the following: ``` [DBG] RPCS: [/lnrpc.Lightning/CloseChannel] requested [WRN] RPCS: Expected either 'sat_per_vbyte' or 'conf_target'...
Other commands may be also affected by this: cmd/commands/cmd_open_channel.go: `lncli channelopen` cmd/commands/commands.go: `lncli sendcoins` `lncli sendmany` `lncli closeallchannels` All of them have flag `sat_per_vbyte` which is of int64 type. I...
Please sign your commits: https://github.com/lightningnetwork/lnd/blob/master/docs/development_guidelines.md#sign-your-git-commits
Please also change it for this command: cmd/commands/cmd_open_channel.go: `lncli channelopen`
@Suvrat1629 I'm not aware about a method this fix can be tested automatically. It is a fix of lncli, not lnd, so it can't be tested in itests IIUC.
@Suvrat1629 I reworked the test and pushed the patch to this PR. If you like the approach, please squash all the commits and extend the test with other affected commands.
@Suvrat1629 Check this how to squash multiple commits into one: https://stackoverflow.com/a/5189600
@Suvrat1629 The commit structure should be clear. There should not be merge commits in the PR. You can do this: ``` $ git pull --rebase https://github.com/lightningnetwork/lnd master ``` This will...