Boris Nagaev comments

Results 118 comments of


                                            Boris Nagaev

Extend signetchallenge to set target block spacing

Rebased to resolve conflict.

chanbackup, server, rpcserver: put close unsigned tx, remote signature and commit height to SCB

Rebased on top of 0.18, added release notes, updated PR description. Retested manually using [chantools scbforceclose](https://github.com/lightninglabs/chantools/pull/95).

chanbackup, server, rpcserver: put close unsigned tx, remote signature and commit height to SCB

@guggero Thanks for the review! 💯 I fixed the comments. Also I moved function `SignCloseTx` from chantools PR here and used it in itest which tests the following cases: -...

chanbackup, server, rpcserver: put close unsigned tx, remote signature and commit height to SCB

Rebased. Moved the release notes change to 0.18.3.

chanbackup, server, rpcserver: put close unsigned tx, remote signature and commit height to SCB

@guggero Thank you for review! I addresses the feedback. Also, I checked the failures in CI. The failures of itests on windows and "unit tests (btcd unit-cover)" seem to be...

chanbackup, server, rpcserver: put close unsigned tx, remote signature and commit height to SCB

Neutrino itests are passing now in CI. Windows itests fail, but they are flacky in master branch. Failures seem to be unrelated to the PR. btcd unit-cover tests fail in...

chanbackup, server, rpcserver: put close unsigned tx, remote signature and commit height to SCB

I rebased the PR and fixed itest build errors (changes in ht interface and chanRestoreViaRPC function). Also removed waiting for tx in mempool and added waiting for ClosedChannels call next...

adding Cyrus SASL, MIT Kerberos V and OpenLDAP

Adding cyrus-sasl: commit 2f2ba1ba42b893d27fbf93a7288e6f983e0423c1 Linking errors on shared build: https://gist.github.com/9c2804bb18ed356a818b I [disabled](https://github.com/LuaAndC/mxe/blob/2f2ba1ba42b893d27fbf93a7288e6f983e0423c1/src/cyrus-sasl-1-fixes.patch#L212) dllimport and dllexport in one of patches to fix linking errors in static build. It may be related...

adding Cyrus SASL, MIT Kerberos V and OpenLDAP

@mgerhardy, thanks! OpenLDAP depends on Cyrus SASL, not on GNU SASL.

As someone new to web, but not new to Lua, I feel the HTTP request documentation is severely lacking.

You can access all the GET, POST, and URL parameters together in a variable `self.params`. Read more [about Request Object](http://leafo.net/lapis/reference/actions.html#request-object).