Boris Nagaev

Results 118 comments of Boris Nagaev

Strong +1 for this PR! It fixed go-callvis crash in my project. I'm using Go 1.22

Hi @javierron ! Thank you very much for the review! I addressed the feedback, see my comments. > Maybe the solution is to determine at initialization if a pattern is...

Hi @javierron @monperrus ! I think it is possible to implement `func analyzePattern` without hardcoded tables. Go has package [regexp/syntax](https://pkg.go.dev/regexp/syntax) which provides introspection of regular expressions. I think it is...

Try the following command: ``` $ luarocks install luacrypto 0.3.2-1 --local ```

[The official rockspec](https://luarocks.org/manifests/luarocks/luacrypto-0.3.2-1.rockspec) for luacrypto has the following Lua version line: ``` lua dependencies = { "lua >= 5.1, < 5.3", } ``` That is why luarocks doesn't list this...

> Any idea when LuaCrypto rockspec will be updated in the main repository? Unfortunately, the main repo seems abandoned.

More generic error messages provide less information useful to debug. If a user gets this message and sends it to a developer, then the latter can't distinguish various possible sources...

If lexer should be a disposable object, please document it and throw an exception, when it is tried to be parsed twice.

Hmm, I am not sure that this is correct. The actual eviction happens in CompareAndSwapPointer, not in ItemDecRef.

It is necessary to post the proof on blockchain at least in non-cooperative scenario to enforce the penalty for the host for not storing the data. Absence of a proof...