Markus Staab

Results 1121 comments of Markus Staab

I managed to reproduce it in https://github.com/phpstan/phpstan-src/pull/2897 - see https://github.com/phpstan/phpstan-src/actions/runs/7744684608/job/21118995083?pr=2897 could you have a look into a possible fix? I had a look already, but this stuff looks pretty complicated...

after hours of investigation the only way I see this could be fixed - without regressing existing expected errors - would be to gather all property-fetches of `__construct()` until the...

I think the current test-cases like e.g. https://github.com/phpstan/phpstan-src/blob/29a68b75ce9fa885886395df1acd23c06cff2a14/tests/PHPStan/Rules/Properties/data/missing-readonly-property-assign.php#L231-L246 work because the methods are called directly from `__construct`. the difference in my repro-case is, that the caller is a "additionalConstructor" and...

after a lunch walk I got an idea and implemented a fix in https://github.com/phpstan/phpstan-src/pull/2897

I wonder whether we could/should make line 23 report `RemoteIssueLink` instead of `mixed`

> The PHPDoc is invallid? I agree, but on the other hand `ArrayObject` claims to be a class which acts like an array. Therefore I thought about whether we would...

I have started working on this and will PR a first draft after my other open PRs are finished

Dumping the types reveals the PHPStan internal types and makes the bug obvious https://phpstan.org/r/a42ff812-3bbc-40ba-b687-b7433c9002c8

just leaving some details here while working on it: profile of the given example https://blackfire.io/profiles/20da814a-2056-40c7-a892-8aec97d58971/graph unsuprisingly cause is a big union. diving deeper now.