Markus Staab

Results 1119 comments of Markus Staab

looking at the [PHP-CS rule for "final-classes"](https://cs.symfony.com/doc/rules/class_notation/final_class.html) they strike a pretty hard balance: > If you want to subclass a class, mark the parent class as abstract and create two...

> I was thinking about standalone tool for a while, due to the full-context issue. Looking into it 🙄 Makes sense. Maybe this tool should bundle other rector rules which...

> E.g. the `FinalizePublicClassConstantRector` does not bring much value, as `final` class resolves it in much better way. I agree that these rector does not provide much value. but from...

I also had a look at `StringableForToStringRector`, which adds `implements Stringable` by using `FamilyRelationsAnalyzer`. I don't understand what the value of this rule is, because as I understand the `Stringable`...

I see - thank you. I tried to ignore this error via `roave-bc-check.yaml` ``` parameters: ignoreErrors: - '#\[BC\] SKIPPED: Roave\\BetterReflection\\Reflection\\ReflectionClass "SoapClient" could not be found in the located source#' -...

Oh I see. Is there a different way of ignoring errors?

@sebastianbergmann does this PR depend on the exporter object PR or can it land independently for 11.x ?

Thanks for the support. I would also have a look at this PR after vacation

No worries. Please go ahead