Markus Staab

Results 959 comments of Markus Staab

The same is true for [Typo](https://github.com/OskarStark/doctor-rst/blob/16f99e8b6600b153fee01f81f77aeaf82dd27717/src/Rule/Typo.php#L56-L77) ![grafik](https://github.com/OskarStark/doctor-rst/assets/120441/2cbbd90b-86fe-4429-b09c-44356d4aa0ca)

if someone will resolves the above mentioned 2 remaining issues most low hanging fruits are fixed

I think this means we should report the error only for final classes? detecting whether a method is overridden by some subclass is a bigger challenge and can depend on...

for now I have implemented the `looseCompare` methods for all types. now I need to have a look at the failling tests and afterwards type narrowing

I have implemented a few basic types and added tests for them in `loose-compare.php`. please have a look whether this is done how you imagined it. btw: this PR will...

I added tons of tests and implemented `looseCompare` on a lot of types. I happy for everyone giving feedback, since there are a lot of test-cases added and its pretty...

ondrej, do you agree that we can implement only the most common types (all scalars, arrays, basic object types) with this PR, while leaving more specialized ones for a future...

I think this one was fixed with recent releases. can you confirm?

@p4veI in https://github.com/staabm/phpstan-dba/pull/505 landed the initial implementation/integration of a sql parser