phpstan-src icon indicating copy to clipboard operation
phpstan-src copied to clipboard

Resolve substr based on configured PHP version

Open VincentLanglet opened this issue 5 months ago • 3 comments
trafficstars

Closes https://github.com/phpstan/phpstan/issues/13129

VincentLanglet avatar Jun 13 '25 06:06 VincentLanglet

This pull request has been marked as ready for review.

phpstan-bot avatar Jun 13 '25 07:06 phpstan-bot

btw: since phpunit got upgraded on the PHPStan 2.x branch, we need to be careful to send PRs to PHPStan 1.12.x only when easy mergabe into 2.x (attributes got added etc)

staabm avatar Jun 13 '25 07:06 staabm

btw: since phpunit got upgraded on the PHPStan 2.x branch, we need to be careful to send PRs to PHPStan 1.12.x only when easy mergabe into 2.x (attributes got added etc)

Only change is this attribute https://github.com/phpstan/phpstan-src/blob/2.1.x/tests/PHPStan/Analyser/LooseConstComparisonPhp7Test.php#L24

I dunno if it will even create a conflict but if ondrej ask, I can target 2.1.x instead :)

VincentLanglet avatar Jun 13 '25 07:06 VincentLanglet

I'd prefer this one only for 2.1.x :) Thanks.

ondrejmirtes avatar Jul 17 '25 12:07 ondrejmirtes

Rebased on 2.1.x @ondrejmirtes

VincentLanglet avatar Jul 17 '25 12:07 VincentLanglet

Thank you!

ondrejmirtes avatar Jul 17 '25 15:07 ondrejmirtes