Shane Smiskol

Results 382 issues of Shane Smiskol

car
tesla
car safety

Would remove some complexity in the safety if it works. @sunnyhaibin can you have a tester try this with stock long? Is my understanding correct that this only applies to...

car
hyundai
car safety

re-merge https://github.com/commaai/opendbc/pull/1785 but with everything - [ ] dynamic AEB (or generic message?) forwarding

refactor
car safety

can start with only while testing, shouldn't have to place comments everywhere to find out

enhancement
CI / testing
car safety

summon and autopark: https://connect.comma.ai/2c912ca5de3b1ee9/000000b1--77e4f8b8bf

car safety

![image](https://github.com/user-attachments/assets/d07f87f6-7fc5-47e1-8fa7-12c521bacbd9) ![image](https://github.com/user-attachments/assets/68848155-8105-48ae-a853-35f1cf9a9126)

enhancement
car
tesla

On Toyota, the PCM status message (`PCM_CRUISE`) also has the gas pressed bit, so if you for example change some code that should fail a test: ```c if (!cruise_engaged) {...

bug

Blocking new model ports until this is done, it's almost impossible to work on the safety without a good chance of introducing bugs.

cleanup
car
hyundai
car safety