Sabet Seraj

Results 48 comments of Sabet Seraj

@anilyil @eirikurj Any updates on this? We should probably merge this soon.

> Is using 'useexternaldynamicmesh' to define grid motion is the only way for now to run TS analysis? Yes, this is the only way that currently works. > For another...

This occurs with any of the "max" monitor variables: https://github.com/mdolab/adflow/blob/cd6ec63f37e3d8027aeba1a8ae071e6e7a8e501d/src/solver/solvers.F90#L1428-L1438 The maximum value doesn't have a meaning for complex numbers, so I think the fix would just be to cast...

> Other than this, did you have any other comments I did not address? Nothing else to address from me. I'm fine with adding a test later.

I don't know what's going on with the complex build because both of the last commits work for me locally. For context, I tried changing complexify.py to get it to...

This is ready to be merged. @marcomangano @ArshSaja The only Fortran file that has manual changes is `src/preprocessing/preprocessingAPI.F90`. The manual changes were necessary to fix the complex build issue that...

Yes, I will open another PR updating `.git-blame-ignore-revs` after this is merged.

This was fixed in #325 by changing the test. The root cause is unclear except that using too many AMG levels potentially causes memory-related issues.

This issue has all the relevant information, so maybe it is best to just reopen this

Yes, I'll take another look at this and try to run my case as well