Sven Reichel

Results 224 comments of Sven Reichel

Change ``` $sql = $this->quoteInto($text, str_replace("\0", '', $value)); ``` to ```` $value = is_string($value) ? str_replace("\0", '', $value) : $value; $sql = $this->quoteInto($text, $value); ```` should work.

> If it is a confirmed bug, it must be reverted quickly. Later a new PR can be created to solve the issue. Imho ... If it is a confirmed...

Nice, but I can't hit "approve" ... someone is sure to get homicidal urges :P If you have time for, can you check https://github.com/OpenMageModuleFostering how often mysql4 is used?

This should stay open.

This commands are executed after every `composer install` and `composer update` to add additional sniffs to PHPCS. With `--no-dev` flag nothing happens. - `$COMPOSER_DEV_MODE` is to detect if `--no-dev` flag...

No, it does nothing. Just make the tools available. Also no impact for composer installed shops.

Useless PR ... table outup seems better for quick reviews.

As said ... we all have different setups, so ```composer install``` should work for all of us. The composer.lock is usefull if all run the same environment (for the same...

> @sreichel im ok with any approach which will give us stability on CI builds. I really dont know, but what troubles CI not having a composer.lock? > So what...