Sven Reichel

Results 455 comments of Sven Reichel

> Could you post the errors that you face? Of course ... we can do it step by step. First ... just comment lines in functions.php ``` Deprecated functionality: PDOStatement::fetch():...

> I'll try that tonight Thanks. Next step could be default values for `getRequest()->getParam()`

Or ... `escapeHtml()` ... `$data` can be null ... so if it is null, return empty string? ``` /** * Escape html entities * * @param string|array $data * @param...

Yes, it does make no sense to escape null, but currently it is done. I'd prefer the method, that takes most effort. Adding getter/setter methods ...

_This branch has conflicts that must be resolved_

Just asked to resolve conflicts. Having placeholders and aria-label is not wrong.

I'd use @Vinai repo. It's complete and just uses better compressed images.

> You can change the link to Vinai's repository (as DDEV also recommends) based on your arguments.: > https://raw.githubusercontent.com/Vinai/compressed-magento-sample-data/1.9.1.0/compressed-magento-sample-data-1.9.1.0.tgz This link is outdated ... opened PR at ddev to use...

__Thanks__ to @kkrieger85 for issues/PRs at DDEV :+1:

@ADDISON74 Have i missed something? I've added dev-mode, but did not add sample-data, b/c its mentioned at ddev-docs. edit: you can also edit/update this PR :)