Sven Reichel comments

Results 460 comments of


                                            Sven Reichel

Removed the word "Manage" from the Admin menu so all items are named are consistently

Can you please verify that all translations still work? Unused translations should be removed from csv.

Removed the word "Manage" from the Admin menu so all items are named are consistently

This change breaks every locale pack. No! E.g. https://github.com/riconeitzel/German_LocalePack_de_DE translates ... ``` "Manage Products","Artikel verwalten" ```

Removed the word "Manage" from the Admin menu so all items are named are consistently

If you want to change wording, please in CSV only. Extensions may rely on that php string with custom translation.

Table 'dbName.core_file_storage' doesn't exist

Nice catch. This table does no exist in "sample date" too, but is created when you change media storage to DB. So if you migrate a shop where config is...

Use transliterator_transliterate to generate url_key

Is this code (#345) still required?

Merge v19 -> v20

I'm out with my dog for next hours ... and i can't see detailed checks in github app ... Think easiest is to rebuild baseline (I also do this for...

[PHP 8.1] Fix passing null to non-nullable internal function params

When I comment the three lines I get a lot of other errors related to php8.1. It takes some time to test.

[PHP 8.1] Fix passing null to non-nullable internal function params

@kiatng please wait with reviews. I'm also working on a PR that is bit different. (w/o type casting)

[PHP 8.1] Fix passing null to non-nullable internal function params

> I am not sure if blanket type casting the params of PHP functions is a good idea, This is why i put it on hold. > Your thoughts? I'd...

[PHP 8.1] Fix passing null to non-nullable internal function params

@elidrissidev thanks!!! I tried to test it and run into different other errors. This PR is too important, to semi-blindly hit approve. And it's to large to test it properly....