Sven Reichel
Sven Reichel
> Again, not my opinion and there is no official rule for that. This is why i just said _i'd prefer_ .... whatever.
@fballiano big sorry. It was not meant rude. I justed wondered why "force-push" is used since some time. If someone suggested to use this ... okay.
How about a RSS notification to re-set this value in admin config?
Mhhh ... i'm not so happy to check for an orphan config entry just for BC. How about an update script that move value from old to new config path?...
@colinmollenhour it's not about "overhead". Why to deal with a non-existing config node? Simple update script .... ```php
> and we remove the "require" of this new repo from v20? > > EDIT: actually why should this be in v19? Go away :angry: I prefer the current workflow...
@fballiano i would neither add it to 19.x, nor 20.x. I'd add it to your release-builder to maintain BC. Everyone who uses composer can add it if necessary.
> However, a migration script and clear and concise information are mandatory. Please check the other PR where this script was also included. A combination of ideas is welcome. i'm...
Not sure about this. Can you please keep the docblocks? Tools like phpDocumentor use them. Observer returns can be used outside, see https://github.com/AOEpeople/Aoe_Scheduler/blob/master/app/code/community/Aoe/Scheduler/Model/Schedule.php#L229-L259 Maybe it would be better to add...
1.) phpDocumentor ... tested. You're right. Redunant docblocks are not needed. Maybe I had that in mind from php5 ... 2.) cronjobs also accept observer-methods as callback ... `app/code/core/Mage/CatalogRule/etc/config.xml` ```...