Reiner Gerecke

Results 117 comments of Reiner Gerecke

All that's left are those incompatible errors. The one in production overview to me is not all clear whether that should be an error or not: > Definition of "show"...

First step (`Fix issues raised when running mypy on clean codebase (mypy --py2 --silent-imports --fast-parser -p horizons)`) is done. We still get lots of issues related to inheritance (https://github.com/unknown-horizons/unknown-horizons/issues/2513#issuecomment-257078652), but...

Variable annotations (Not using comments) are now possible. Other than that, we've already been using this. This thread and commits are proof of that. There ist no point in waiting....

So apparantly we planned to switch over to python 3.5 when we started working on this. The typing module was only included in python3.5, that's why isort is complaining now...

Pretty sure this is caused by the label displaying the message. Look what happens when I display many lines: ![2017-05-22-070304_839x625_scrot](https://cloud.githubusercontent.com/assets/50333/26293410/ca0f4732-3ebc-11e7-9aab-8f257644119b.png) Ignore for now that the `` is missing, still experimenting.

The issue is that vertical text alignment is hardcoded to be centered here: https://github.com/fifengine/fifechan/blob/master/src/widgets/label.cpp#L134 ```c int textY = offsetRec.y + getPaddingTop() + (getHeight() - offsetRec.height - getPaddingTop() - getPaddingBottom() -...

See this issue to get the required functionality: https://github.com/fifengine/fifechan/issues/52

@LinuxDonald I fixed the size of the message labels, so the text centering is now at least consistent and doesn't look off. I'm gonna mark this issue as nice-to-have.

After fixing the message label size: ![2017-05-22-081100_1324x843_scrot](https://cloud.githubusercontent.com/assets/50333/26294726/326afc1e-3ec6-11e7-9833-dae88757f93b.png)

Just change your ingame language and see for yourself. You might have to build translations first though.