Reiner Gerecke
Reiner Gerecke
Oh noes. I completely forgot about it, because I was busy asking for help with contributing a bugfix. I can do that later today if no one else is quicker.
The suggestion on gitter was to just include the dependency in our package. Unfortunately I'm not familiar with the packaging process here at all, so I was unable to provide...
Yeah, I really don't want to do that. Which is why I suggested somehow including it in the packaging process. mypy is a development tool, I should be able to...
That won't work in Python 3 as I said. There you'd write ``` python def foo(x: Any) -> List[int]: return [1,2,3] ``` instead of ``` python def foo(x): # type:...
I can't recall any plans to ever include it. The PEP was written with no specific implementation in mind. You can define type hints, but the interpreter doesn't do anything...
Oh. Guess I was wrong. So the stuff `typing` does is then part of the PEP, I see. I'm a bit surprised, I thought they were actively developing typing as...
I think this then is the way to go: 1. include python2 backport of typing in `horizons.ext` 2. adapt imports to read `from horizons.ext.typing import Any, ...` (unconditionally) 3. once...
Packages like `horizons.gui.modules`, `horizons.gui.keylistener` and `horizons.gui.tabs` trigger an bug in mypy: https://github.com/python/mypy/issues/2052 ``` horizons/gui/keylisteners/mainlistener.py:33: error: Module 'horizons.gui.keylisteners' has no attribute 'KeyConfig' horizons/gui/keylisteners/ingamekeylistener.py:25: error: Module 'horizons.gui.keylisteners' has no attribute 'KeyConfig' ```...
> I'm an code noob but does it makes code easier to ready? The advantage is that one can restructure whole modules (like `horizons.gui.tabs`) without renaming imports of files inside...
Step one is _almost_ done. Ignoring errors from global gettext functions we get this: https://gist.github.com/squiddy/c6dd6479da8cd5b7495374fd4ba85acf The majority of errors is of the form: `Definition of "" in base class ""...