Reiner Gerecke

Results 117 comments of Reiner Gerecke

Clippy & rust have traits for "passes". `EarlyLintPass` for AST information, `LateLintPass` after type checking etc. `REDUNDANT_FIELD_NAMES` would use those like this (excerpt): ```rust impl EarlyLintPass for RedundantFieldNames { fn...

Oh yeah, I get it. Initially I also wouldn't use macros but just type it out first. Syntactic sugar/shortcuts can come later. I think in the case of clippy the...

```rust pub struct CheckDef { pub name: &'static str, pub description: &'static str, pub code: CheckCode, pub category: CheckCategory, pub lint_source: LintSource, } pub struct Check { pub definition: &'static...

This seems to be handled by `ImportStarUsage` already, doesn't it?

> it just adds a bit of complication so I've been putting it off. Could you please elaborate on that? I've done some reading and doing #658 and #659 seems...

Just putting this up here. ```rust pub trait AstPass { fn check_classdef(&self, checker: &mut Checker, stmt: &Stmt) {} fn check_call(&self, checker: &mut Checker, expr: &Expr) {} ... } pub struct...

I'll look at `yield -> yield from`.

I'm working on `python-no-log-warn`.

Working on `python-check-blanket-type-ignore` now.