Reiner Gerecke

Results 117 comments of Reiner Gerecke

@LinuxDonald I can't say at this point. Have to become familiar with overlays first.

I briefly looked into this and one issue is that some parts of the code are extending enums, especially the ai IIRC.

I'd like to see that, but I have my doubts that our current UI system can handly that elegantly.

No clue, haven't used it in a while. The logging still works fine though, it's just that there are exception raised when closing the game. Minor issue really.

Going to have a look at it. Log handling in the `run_uh.py` file looks a bit messy.

Indeed. The article in question (I believe it's [the one from Tulip](http://blog.zulip.org/2016/10/13/static-types-in-python-oh-mypy/)), says to start off with `mypy --py2 --silent-imports --fast-parser -i `. Once that works, one should add `--check-untyped-defs`...

I'd say we skip checking the tests for now, especially in GUI tests a lot of monkey-patching is going on.

I'm working on the first step and I'm wondering how we should handle the following problem (so far I haven't found clues in the documentation): ``` python from typing import...

I thought that was merely about imports solely for the purpose of type hints, that if always imported, could cause import cycles. But you're right, the following should work: ```...

However, once we move to python3 this won't work I think, because the type hints become part of the code. Therefore they need to be imported unconditionally. I've read something...