Rasheed Abdul-Aziz

Ascii art not good for CI

3

Ascii art only renders well in the console. Log output, say in a CI server log, looks really atrocious. Can has -disable-ascii? Thanks for the script by the way :)

`cf push --var value="012345678.91234456678"` treats value as a number

3

**Please fill out the issue checklist below and provide ALL the requested information.** - [x] I reviewed open and closed github issues that may be related to my problem. -...

Fix a small logging mistake and clean up

1

Fix a small logging mistake and clean up # clean up - Use a specific error name for each section of the realizer (see note) - merge two realizeError conditionals...

This deepcopy only gives us a copy of a garbage collected value anyway

1

Co-authored-by: Sam Coward

[PR requirements]: https://github.com/vmware-tanzu/cartographer/blob/main/CONTRIBUTING.md#commit-message-and-pr-guidelines ## Changes proposed by this PR closes # ## Release Note [imperative mood]: https://chris.beams.io/posts/git-commit/#imperative ## PR Checklist Note: Please do not remove items. Mark items as done...

Runnable should have name of stamped object in its status

1

Runnable should reference the stamped object currently reflected in the status. In worklaods and deliverables each resource that was stamped is referenced in a [`stampedRef' field](https://github.com/vmware-tanzu/cartographer/blob/f7de1658439afc420fd59dcd14c1d4d0cdba43d3/pkg/apis/v1alpha1/common.go#L207) We should do the...

Test does nothing

1

[This test](https://github.com/vmware-tanzu/cartographer/commit/6098ac9ba25c6a96662dd6a1697f76ef5b60e0bc#diff-023ff4eca301e6692407497413b0cfe393fc6c0edfabe8f738b6df029e8054e5R708) doesn't do anything. I'm removing it but we should revisit the intention of it and implement if it's useful.

Currently runnable uses a `DiscoveryClient` to find out if a resource is scoped to a cluster or namespace. This can easily overwhelm our API call rates, and it's already cached...

### Description of problem Today, a blueprint with a resource that contains a _forward_ source/image/config/deployment resource reference will fail with `failed to interpolate map value: ....... evaluate: failed to find...

Only run E2E, release and update tests when include-list directories change

1

### Description of problem Some folders contain documentation that should not trigger e2e If I change an RFC, tests are triggered in GH Actions, and this leads to slow turnaround...