cartographer icon indicating copy to clipboard operation
cartographer copied to clipboard

Fix a small logging mistake and clean up

Open squeedee opened this issue 3 years ago • 1 comments

Fix a small logging mistake and clean up

clean up

  • Use a specific error name for each section of the realizer (see note)
  • merge two realizeError conditionals

fix

logging tracking error instead of realize error when the tracking fails

Note

The number of different actions with different errors in #Reconcile feels like a code smell. We're already concerned by the complexity of reconcile so this is not a surprise, just further evidence.

squeedee avatar May 24 '22 15:05 squeedee

This is not mergable due to realizers getting unified. Will re-implement

squeedee avatar Aug 15 '22 16:08 squeedee

implemented here: https://github.com/vmware-tanzu/cartographer/pull/1040

squeedee avatar Sep 27 '22 18:09 squeedee