Siddarthan Sarumathi Pandian
Siddarthan Sarumathi Pandian
Hi @jeherve! I needed a confidence check on testing extension files. Is there anything special we need to keep in mind when testing extension files such as this one `projects/plugins/jetpack/extensions/blocks/tiled-gallery/tiled-gallery.php`...
This is working fine, @gmjuhasz! Thanks for incorporating the comments. I can give another +1 after the tests are updated!
I know this is not a big PR, but I think it's better to break this down into separate PRs and keep things specific. The changes in the `projects/plugins/social/src/class-jetpack-social.php` can...
>It's all about initial state. I think it's better to make this change together. I think we should proceed with caution, I feel this is a risky change to be...
Thank you so much for breaking it down, I appreciate it. 🙌 I had a few thoughts, don't hate me please: - I think the connection results bit can be...
>Connection test results change is what you see in publicize and social initial state. Thanks, for some reason in my head, I kept the editor changes separate from the admin...
This might need some more investigation, we can do a quick spike and decide the next steps. Adding this to the next iteration.
>Other servers work fine Could you give me the name of a different served you tested with? I wanted to sign up on it and try. >I believe the problem...
We are investigating this still, I will report back with an update as soon as we have one.
Yeah, just wrapping up my tests